-
Notifications
You must be signed in to change notification settings - Fork 25
I have implemented parse_roman() function #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AmPhIbIaN26
wants to merge
22
commits into
scrapinghub:master
Choose a base branch
from
AmPhIbIaN26:parse_roman(regex-approach)
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 10 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
61f57d7
Implemented parse_roman() function
AmPhIbIaN26 6664b6f
Moved test_numeral_roman.py
AmPhIbIaN26 376db40
Implemented roman_numera()l function
AmPhIbIaN26 ce4e5c6
Adding numeral_system as a parameter to functions
AmPhIbIaN26 6d420a7
added _valid_input_by_numeral_system()
AmPhIbIaN26 bf7d6e3
Added NUMERAL_SYSTEMS
AmPhIbIaN26 5104b76
fixed Unicode issue for Hindi, Spanish and Russian
AmPhIbIaN26 94d9441
Update test_numeral_roman.py
AmPhIbIaN26 475ad04
Update test_number_parsing.py
AmPhIbIaN26 f847cf6
Merge pull request #1 from AmPhIbIaN26/parse_roman(numeral-support)
AmPhIbIaN26 45bfdc5
Update README.rst
AmPhIbIaN26 c13102f
Merge pull request #2 from AmPhIbIaN26/parse_roman(numeral-support)
AmPhIbIaN26 973664b
Delete test.py
AmPhIbIaN26 0e89680
Made all the changes and added support for incorrect roman numbers
AmPhIbIaN26 9704eff
Removed .lower() from roman regex expressions
AmPhIbIaN26 554d553
Update test_numeral_systems.py
AmPhIbIaN26 77ae66f
Merge pull request #3 from AmPhIbIaN26/parse_roman(numeral-support)
AmPhIbIaN26 fb9bff7
Update number_parser/parser.py
AmPhIbIaN26 480cf7c
Update number_parser/parser.py
AmPhIbIaN26 faecf42
Merge pull request #4 from AmPhIbIaN26/parse_roman(regex-approach)
AmPhIbIaN26 cbc4661
Added more test cases for better code coverage
AmPhIbIaN26 086f5ec
Merge pull request #5 from AmPhIbIaN26/parse_roman(numeral-support)
AmPhIbIaN26 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| from number_parser.parser import parse, parse_number, parse_ordinal, parse_fraction | ||
| from number_parser.parser import parse, parse_number, parse_ordinal, parse_fraction, NUMERAL_SYSTEMS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| from number_parser import parse ,parse_number | ||
|
|
||
| print(parse_number('built in CDXX', numeral_system='roman')) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.