Skip to content

Added a Feature of Ignoring some number tokens#74

Open
dhananjaypai08 wants to merge 5 commits intoscrapinghub:masterfrom
dhananjaypai08:master
Open

Added a Feature of Ignoring some number tokens#74
dhananjaypai08 wants to merge 5 commits intoscrapinghub:masterfrom
dhananjaypai08:master

Conversation

@dhananjaypai08
Copy link
Copy Markdown
Contributor

@dhananjaypai08 dhananjaypai08 commented Jan 6, 2022

Fixes #5
Ignore parameter right now is for only the parse function(can also implement for parse_number and parse_ordinal once reviewed)
Ignoring parameters present in the ignore list and not parsing it to a number and simply adding it as it is to the output string and then keep building further. Also have added few test cases in test_number_parsing for the same. Let me know what you think and can update the Readme once its approved.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 6, 2022

Codecov Report

❌ Patch coverage is 96.15385% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.15%. Comparing base (8367865) to head (4fd5e95).
⚠️ Report is 16 commits behind head on master.

Files with missing lines Patch % Lines
number_parser/parser.py 96.15% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   98.78%   99.15%   +0.37%     
==========================================
  Files          86       86              
  Lines         328      356      +28     
  Branches       61       69       +8     
==========================================
+ Hits          324      353      +29     
+ Misses          1        0       -1     
  Partials        3        3              
Files with missing lines Coverage Δ
number_parser/parser.py 98.89% <96.15%> (+0.53%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dhananjaypai08 dhananjaypai08 changed the title Added a Feature of Ignoring a number tokens Added a Feature of Ignoring some number tokens Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ignore parameter

1 participant