Open
Conversation
Contributor
|
I agree with the need for simplicity/concision at the necessary pipes to extract the data in the provided example above. Given the current grammar, from the "logical" point of view makes sense to use the Another thing that I found exploring this example is that the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test need not be merged into master but instead provides the necessary stimuli to see some pain points in
shublang's usage.In particular we can see that:
The current
sanitizefunctionality returns empty strings in its iterable. This presents the need to update it to prune out the empty strings, otherwise it would evaluate our test example as['', '', '', 'price: $123,823.00', '']We need to do a double
first, since the 1st one transforms[('123823.00',)]into('123823.00',)and the 2nd one transforms(123823.00,)into123823.00.The
floatfunctionality needs to be in between the doublefirstsince it only works on iterables.As we can see, we need to jump on a lot of hoops just to properly extract this type of data.
Ideally, we should have a way to extract the data in a very concise manner like:
re_search("(\d+\.\d{2}) | first_match