Skip to content

added: New API endpoint _cache_control. Solves #203#339

Open
starrify wants to merge 1 commit intoscrapinghub:masterfrom
starrify:add-caching-options
Open

added: New API endpoint _cache_control. Solves #203#339
starrify wants to merge 1 commit intoscrapinghub:masterfrom
starrify:add-caching-options

Conversation

@starrify
Copy link
Copy Markdown
Member

@starrify starrify commented Nov 19, 2015

Fixes #203

@codecov-io
Copy link
Copy Markdown

Current coverage is 85.45%

Merging #339 into master will decrease coverage by -0.02% as of 9c34085

@@            master    #339   diff @@
======================================
  Files           40      40       
  Stmts         4655    4675    +20
  Branches       631     638     +7
  Methods          0       0       
======================================
+ Hit           3979    3995    +16
+ Partial        151     150     -1
- Missed         525     530     +5

Review entire Coverage Diff as of 9c34085

Powered by Codecov. Updated on successful CI builds.

@kmike
Copy link
Copy Markdown
Member

kmike commented Dec 1, 2015

Hey @starrify,

The feature makes sense, but I think it is not good to allow to set these options via HTTP API: they should be set at startup like other global Splash options.

@nramirezuy
Copy link
Copy Markdown

hey @starrify, was this working properly before? Because right now it seems to be ignoring QSettings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

disable browser/webkit caching ?

4 participants