Skip to content

Add typing for the newly added console.logUnsafe function#288

Closed
tiennou wants to merge 1 commit intoscreepers:masterfrom
tiennou:feat/logUnsafe
Closed

Add typing for the newly added console.logUnsafe function#288
tiennou wants to merge 1 commit intoscreepers:masterfrom
tiennou:feat/logUnsafe

Conversation

@tiennou
Copy link
Copy Markdown
Contributor

@tiennou tiennou commented Jan 30, 2026

Brief Description

Not sure if this is proper to do it that way, since we don't have a dependency on the DOM types being here, but that should at least make TS not frown at the function.

Checklists

  • Test passed
  • Coding style (indentation, etc)
  • Edits have been made to src/ files not index.d.ts
  • Run npm run compile to update index.d.ts

@ShuP1
Copy link
Copy Markdown

ShuP1 commented Mar 16, 2026

Screeps console object is not compliant with neither a Node nor browser console.
So I think we should put all methods in this Console interface and stop relying on @types/node

@ShuP1 ShuP1 mentioned this pull request Mar 16, 2026
4 tasks
@tiennou
Copy link
Copy Markdown
Contributor Author

tiennou commented Mar 16, 2026

Yeah, that's fair. Closing this one.

@tiennou tiennou closed this Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants