add tests for reading of legacy files (closes #92) - #168
Conversation
99c7722 to
94ed597
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #168 +/- ##
==========================================
- Coverage 91.12% 91.11% -0.02%
==========================================
Files 11 12 +1
Lines 1826 1857 +31
==========================================
+ Hits 1664 1692 +28
- Misses 162 165 +3
🚀 New features to boost your workflow:
|
d6530c7 to
804ccd1
Compare
Reference files are generated with src/mudata/tests/reference.py. This is based on the mudata fixture in tests/conftest.py, but it had to be modified, since NumPy does not guarantee stability of its random number generator across versions, so this needs to be completely deterministic.
804ccd1 to
69606bf
Compare
ilan-gold
left a comment
There was a problem hiding this comment.
Main question is: why not use h5diff for the newer file versions? #92 (comment) seems to only say some subset of the older verisons would not work under this (I think only the v0.1.2?)
|
|
Reference files are generated with
src/mudata/tests/reference.py. This is based on the mudata fixture intests/conftest.py, but it had to be modified, since NumPy does not guarantee stability of its random number generator across versions, so this needs to be completely deterministic.See also the discussion in #92 .