-
Notifications
You must be signed in to change notification settings - Fork 117
use numba progress in threadpool #1220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
selmanozleyen
wants to merge
11
commits into
scverse:main
Choose a base branch
from
selmanozleyen:chore/numba-progressbar
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
257105e
use numba progress for in threadpool
selmanozleyen 15ec58f
Update _utils.py
selmanozleyen 63c5b0f
Merge branch 'main' into chore/numba-progressbar
selmanozleyen 69a88ba
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 5e68369
Merge branch 'main' into chore/numba-progressbar
selmanozleyen a51cc30
Merge branch 'main' into chore/numba-progressbar
selmanozleyen b46da00
refactor: make progress_bar a contextmanager generator
selmanozleyen 4f488bc
refactor: dedupe thread_map result collection loop
selmanozleyen 91e7666
refactor: inline progress_bar into thread_map
selmanozleyen 391a98e
refactor: drop nullcontext/typing helpers in thread_map
selmanozleyen 593f49d
refactor: guard numba_progress import behind show_progress_bar
selmanozleyen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to annotate the return type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find the pattern a bit too complicated for what we're doing there? Maybe just refactor as a context manager, then we avoid that issue and have simpler typing too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
like