-
Notifications
You must be signed in to change notification settings - Fork 49
Fix TLS setup between SM and SM DB #4801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
35b60e4
9c9d120
1ce0930
e115629
ae0fd82
63273fa
aa0b027
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,11 @@ | ||
| http: [::]:5080 | ||
| https: [::]:5443 | ||
| http: "[::]:5080" | ||
| https: "[::]:5443" | ||
|
|
||
| logger: | ||
| level: info | ||
| development: true | ||
|
|
||
| database: | ||
| hosts: | ||
| - [2001:0DB9:200::100] | ||
| - "2001:0DB9:200::100" | ||
| timeout: 1s |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| http: "[::]:5080" | ||
| https: "[::]:5443" | ||
|
|
||
| logger: | ||
| level: info | ||
| development: true | ||
|
|
||
| database: | ||
| hosts: | ||
| - "2001:0DB9:200::100" | ||
| ssl: true | ||
| port: 9142 | ||
| timeout: 1s | ||
|
|
||
| ssl: | ||
| cert_file: /etc/scylla-manager/certs/ca.crt | ||
| validate: true | ||
| user_cert_file: /etc/scylla-manager/certs/cl.crt | ||
| user_key_file: /etc/scylla-manager/certs/cl.key | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| http: "0.0.0.0:5080" | ||
| https: "0.0.0.0:5443" | ||
|
|
||
| logger: | ||
| level: info | ||
| development: true | ||
|
|
||
| database: | ||
| hosts: | ||
| - "192.168.200.100" | ||
| ssl: true | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. WDYT about removing "ssl: true" completely ? It would make sense if we skip cert validation, but this PR is opposite - it forces certificate validation
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think I follow. Removing
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. From UX perspective - I see ssl: true as an unnecessary boilerplate when you include certificates into the config. Comment is about this UX exactly. But it's nit. If we skip cert validation - then ssl: true without certs could mean - encrypt transmission but do not verify certs.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Actually, there are small differences in behavior controlled by the We might want to think about making it so we always validate TLS certs against both system and custom CA (if specified), so that the CA case is more comprehensive, but for now we can't just remove the
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Or did you mean to just not require |
||
| port: 9142 | ||
| timeout: 1s | ||
|
|
||
| ssl: | ||
| cert_file: /etc/scylla-manager/certs/ca.crt | ||
| validate: true | ||
| user_cert_file: /etc/scylla-manager/certs/cl.crt | ||
| user_key_file: /etc/scylla-manager/certs/cl.key | ||
|
Michal-Leszczynski marked this conversation as resolved.
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,11 @@ | ||
| http: 0.0.0.0:5080 | ||
| https: 0.0.0.0:5443 | ||
| http: "0.0.0.0:5080" | ||
| https: "0.0.0.0:5443" | ||
|
|
||
| logger: | ||
| level: info | ||
| development: true | ||
|
|
||
| database: | ||
| hosts: | ||
| - 192.168.200.100 | ||
| - "192.168.200.100" | ||
| timeout: 1s |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| /cqlshrc | ||
| /scylla.yaml | ||
| /scylla-second-cluster.yaml | ||
| /scylla-second-cluster.yaml | ||
| /scylla-sm.yaml |
Uh oh!
There was an error while loading. Please reload this page.