Use the existing bash init file in Darwin to avoid accidentally overriding existing config#15
Open
theRobinator wants to merge 1 commit intosdkman:masterfrom
Open
Use the existing bash init file in Darwin to avoid accidentally overriding existing config#15theRobinator wants to merge 1 commit intosdkman:masterfrom
theRobinator wants to merge 1 commit intosdkman:masterfrom
Conversation
…iding existing config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bash startup is weird and will only read from a single config file when an interactive login shell is started. From the bash man page:
The old behavior of the install script was to always write to
~/.bash_profile. If a user stored their configuration in.bash_loginor.profile, the newly-created.bash_profilewould take precedence over the existing file, causing all existing login config to be ignored.This PR updates the install script to append our init snippet to whatever file the user is already using, only creating a new
.bash_profileif no files already exist.