Refactor auth, some optimization to fetching by ISBN

.github/workflows/pr-tests-dev.yml → .github/workflows/ci-pipeline.yml

@@ -1,9 +1,12 @@
-name: Tests (PR to dev)
+name: CI pipeline
 
 on:
   pull_request:
     branches:
       - dev
+  push:
+    branches:
+      - dev
 
 jobs:
   unit-tests:
@@ -26,7 +29,21 @@ jobs:
           python -m pip install --upgrade pip
           pip install -r requirements.txt -r requirements-test.txt
 
-      - name: Run unit tests
+      - name: Run unit tests with coverage
         env:
           USE_REDIS: "false"
-        run: python -m pytest tests/ -v
+        run: |
+          python -m pytest tests/ -v \
+            --cov=ubiblio \
+            --cov-report=term-missing \
+            --cov-report=xml \
+            --cov-report=html
+
+      - name: Upload coverage reports
+        uses: actions/upload-artifact@v4
+        with:
+          name: coverage-reports
+          path: |
+            htmlcov/
+            coverage.xml
+          if-no-files-found: error

.gitignore

@@ -55,6 +55,7 @@ coverage.xml
 .pytest_cache/
 cover/
 
+
 # Translations
 *.mo
 *.pot
@@ -64,6 +65,7 @@ cover/
 local_settings.py
 db.sqlite3
 db.sqlite3-journal
+sql_app.db
 
 # Flask stuff:
 instance/
@@ -195,4 +197,6 @@ pyrightconfig.json
 # End of https://www.toptal.com/developers/gitignore/api/python,visualstudiocode
 
 config/
-secret_key.txt
+secret_key.txt
+sign_key.txt
+verify_key.txt

pyproject.toml

@@ -0,0 +1,11 @@
+[tool.coverage.run]
+source = ["ubiblio"]
+branch = true
+omit = [
+    "*/tests/*",
+]
+
+[tool.coverage.report]
+precision = 1
+show_missing = true
+skip_empty = true

requirements-test.txt

@@ -1,3 +1,4 @@
 -r requirements.txt
 pytest
 httpx
+pytest-cov

requirements.txt

@@ -15,3 +15,4 @@ aiofiles==24.1.0
 pillow==12.2.0
 uuid==1.30
 requests==2.32.2
+responses==0.25.8

tests/conftest.py

@@ -3,3 +3,20 @@
 
 # Rate limiting uses Redis + FastAPILimiter.init(); tests skip that unless you opt in.
 os.environ["USE_REDIS"] = "false"
+
+
+def pytest_configure(config):
+    """
+    Ensure the SQLite schema exists before any test runs.
+
+    Tests that go through ``TestClient(app)`` get the schema for free because
+    ``ubiblio.main`` calls ``Base.metadata.create_all`` at import time, but tests
+    that exercise lower-level helpers (e.g. ``tests/dependencies/test_auth.py``)
+    don't import ``ubiblio.main``. On a clean CI checkout there's no ``sql_app.db``,
+    so they fail with "no such table: users". Importing the schema here is enough
+    to make either path work.
+    """
+    from ubiblio import models
+    from ubiblio.database import engine
+
+    models.Base.metadata.create_all(bind=engine)

tests/dependencies/test_auth.py

@@ -0,0 +1,21 @@
+import pytest
+from fastapi import HTTPException
+
+from ubiblio.dependencies.auth import get_admin_user, get_user
+from tests.helpers.create_test_user import create_test_user
+
+
+class TestGetAdminUser:
+    def test_admin_user_is_returned(self):
+        with create_test_user(is_admin=True) as test_user:
+            user = get_user(test_user.username)
+            result = get_admin_user(user)
+            assert result is user
+
+    def test_non_admin_raises_403(self):
+        with create_test_user(is_admin=False) as test_user:
+            user = get_user(test_user.username)
+            with pytest.raises(HTTPException) as exc_info:
+                get_admin_user(user)
+        assert exc_info.value.status_code == 403
+        assert exc_info.value.detail == "Only an admin can perform this action."