Move pairing into a module & split logic up into sub-modules. Clean up pairing code. - #123
Merged
Merged
Conversation
… into general/io/wifi, clean up some code
Collaborator
|
Thanks. It's not very clear to me how the code is split between the new files, especially general.rs and io.rs. For example, I see some TcpStream-related code in general.rs. Should that go under io.rs? It might be helpful to add some comments to these files explaining what each is for. |
Collaborator
Author
Thanks for the review! I added some comments in mod.rs explaining the split of responsibilities. How does that look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for adding BLE logic, worked on making the pairing code easier to work with and more modular.
Split some functions up into multiple, fixed some areas that weren't propagating errors, simplified some unnecessary complex logic.