Skip to content

Move pairing into a module & split logic up into sub-modules. Clean up pairing code. - #123

Merged
arrdalan merged 5 commits into
secluso:mainfrom
jkaczman:refactor/camera_hub/pairing
Jun 28, 2026
Merged

Move pairing into a module & split logic up into sub-modules. Clean up pairing code.#123
arrdalan merged 5 commits into
secluso:mainfrom
jkaczman:refactor/camera_hub/pairing

Conversation

@jkaczman

Copy link
Copy Markdown
Collaborator

In preparation for adding BLE logic, worked on making the pairing code easier to work with and more modular.

Split some functions up into multiple, fixed some areas that weren't propagating errors, simplified some unnecessary complex logic.

@jkaczman
jkaczman marked this pull request as ready for review June 25, 2026 16:21
@jkaczman
jkaczman requested a review from arrdalan June 25, 2026 16:21
@jkaczman jkaczman moved this to In progress in v1.2 Release Jun 26, 2026
@jkaczman jkaczman removed this from v1.2 Release Jun 28, 2026
@jkaczman jkaczman moved this from Todo to In progress in v1.1 Release Jun 28, 2026
@arrdalan

Copy link
Copy Markdown
Collaborator

Thanks.

It's not very clear to me how the code is split between the new files, especially general.rs and io.rs. For example, I see some TcpStream-related code in general.rs. Should that go under io.rs? It might be helpful to add some comments to these files explaining what each is for.

@jkaczman

Copy link
Copy Markdown
Collaborator Author

Thanks.

It's not very clear to me how the code is split between the new files, especially general.rs and io.rs. For example, I see some TcpStream-related code in general.rs. Should that go under io.rs? It might be helpful to add some comments to these files explaining what each is for.

Thanks for the review! I added some comments in mod.rs explaining the split of responsibilities. How does that look?

@arrdalan arrdalan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@arrdalan
arrdalan merged commit 10d1a9f into secluso:main Jun 28, 2026
2 checks passed
@github-project-automation github-project-automation Bot moved this from In progress to Done in v1.1 Release Jun 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants