Skip to content

Fix CI: Tests run on windows-latest, which no longer provides VS 2022 #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Fix CI: Tests run on windows-latest, which no longer provides VS 2022 #71

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
596d597
Initial plan
Copilot Aug 2, 2026
30d942e
Fix CI: add windows-2022 to matrix and auto-detect VS version in test…
Copilot Aug 2, 2026
3bba9a2
Merge branch 'main' into copilot/test-windows-2022-and-windows-latest
mcgroarty Aug 2, 2026
01c148e
Add NEWEST_KNOWN_VS_MAJOR sentinel, test_newest_vs_known test, and MA…
Copilot Aug 2, 2026
ffe947b
Clarify comments in ci.yaml
mcgroarty Aug 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
name: Test & Build
strategy:
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
os: [ubuntu-latest, macos-latest, windows-latest, windows-2022]
python-version: ["3.11"]
include:
- os: ubuntu-latest
Expand Down
17 changes: 12 additions & 5 deletions tests/test_source_environment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,9 +320,16 @@ def test_config_shorthand(self):

@needs_cygwin
def test_vstoolset_set(self):
# n.b. This test will need to be updated from time to time:
# AUTOBUILD_VSVER is validated against the Visual Studio versions
# installed on the host system.
with envvar("AUTOBUILD_VSVER", "170"):
# Dynamically discover the latest installed Visual Studio version so
# this test keeps working when the runner image ships a newer VS.
available = atse._available_vsvers()
if not available:
self.skipTest("No Visual Studio install detected")
latest_vsver = available[-1]
major = latest_vsver[:-1]
expected_toolset = atse._VSTOOLSETS.get(major)
if expected_toolset is None:
self.skipTest("No toolset mapping for VS major version %s" % major)
with envvar("AUTOBUILD_VSVER", latest_vsver):
vars = self.read_variables(self.find_data("empty"))
self.assertEqual(vars["AUTOBUILD_WIN_VSTOOLSET"], "v143")
self.assertEqual(vars["AUTOBUILD_WIN_VSTOOLSET"], expected_toolset)
Loading