Move from sys.argv to argparse - #6
Merged
Merged
Conversation
HaroldCindy
approved these changes
Jul 15, 2025
HaroldCindy
left a comment
Collaborator
There was a problem hiding this comment.
Looks reasonable to me, thanks!
Collaborator
|
@FelixWolf Looks like it might require some formatting changes to pass CI https://github.com/secondlife/lsl-definitions/actions/runs/16227903266/job/45978129373?pr=6 |
HaroldCindy
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hoping I understood the "No API changes" policy in the contributing correctly here. (Interpretted it as "No changes to the LSL api", rather than "No changes to the script")
Currently the script is using sys.argv for parsing arguments, which works, with some caveats.
If a argument is missing, it raises a IndexError, rather than an error message on what type of argument is missing.
In addition, there isn't a
-h/--helpto help with listing arguments and available parameters. While this is obtainable by reading the source code, I believe that it would be more helpful to have self documenting arguments.Before:
After
This change was done in a manner to ensure that the arguments follow the same exact syntax as before, as such existing scripts will not break.
There is room for improvement if existing scripts could be modified, for example with
gen_lua_registrations, instead of specifying0or1, we could do--pureas a optional argument, or using argparse's FileType to allow output to stdin / stdout. However a change like that I feel needs to be further looked into and approved, to not break internal scripts that rely on this.I feel, for now, the current changes are sufficient enough to help people further test yaml changes and improvements they make.