Ensure directory exists for gen_func_call_scripts - #7
Merged
Conversation
HaroldCindy
requested changes
Jul 15, 2025
HaroldCindy
left a comment
HaroldCindy
left a comment
Collaborator
There was a problem hiding this comment.
Looks fine in principle, thanks! Just needs some fixups to whitespace to pass CI.
HaroldCindy
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hoping I understood the "No API changes" policy in the contributing correctly here. (Interpretted it as "No changes to the LSL api", rather than "No changes to the script")
Script will crash when calling
gen_func_call_scriptsif the output directory doesn't exist. This ensures the output directory exists when running by callingos.makedirs(output_path, exist_ok=True)before attempting to write to it. If it already exists, gracefully continue.