#6040 Fix object cache logging - #6090
Merged
Merged
Conversation
mReadOnly is an expected state for second instance. There is nothing to fix, nothing to inform of, so it doesn't deserve a warning. Similar for dirty_cache, it's notmal to not have changes there on shutdown. Might even want it as infos
maxim-productengine
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a small adjustment for shutdown logging.
mReadOnly is an expected state for second instance. There is nothing to fix, nothing unexpected, so it doesn't deserve a warning. Similar for dirty_cache, it's notmal to not have changes there on global shutdown. Might even want it as infos (like a region loads and immediately unloads, would trip the warning despite it being expected not to have dirty cache)