Fix LLViewerTexture::getSystemMemoryBudgetFactor result trunction when low on memory - #6138
Closed
Hecklezz wants to merge 1 commit into
Closed
Conversation
Hecklezz
force-pushed
the
fix/getSystemMemoryBudgetFactor_truncation
branch
from
August 14, 2026 14:04
1803225 to
cb45162
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edit: Nevermind, I just noticed that the 26.3 branch has some additional changes not currently in develop that makes this issue not a problem anymore. Closing
Issue Fixed: #6137
Simply casts free_budget to a float so integer division trunction doesn't occur on the result, preventing returning 1.f when a value 1.f < x < 2.f should be returned, or a value of 2.f being returned when a value of 2.f < x < 3.f should be returned, etc.
Before this PR, if the system is low on memory, LLViewerTexture::getSystemMemoryBudgetFactor may have been returning 1.f as if the free_budget is >= 0 even when it isn't.