#6092 'Save As' button in personal lighting floater

[akleshchev]

An option to save personal lightning as a fixed sky setting inventory item

[Copilot]

Pull request overview

Adds a “Save As” workflow to the Personal Lighting (environment adjust) floater so users can save current personal sky settings into a fixed sky settings inventory item, with supporting notifications for failure and texture-permission problems.

Changes:

• Added a Save As button to the Personal Lighting floater UI.
• Implemented onButtonSaveAs() to clone the live sky, validate referenced textures, prompt for a name, and create a settings inventory item (selecting it in inventory on success).
• Added new notifications for save failure and texture permission failures, and reused the existing “SaveSettingAs” prompt.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
indra/newview/skins/default/xui/en/notifications.xml	Adds new notifications for save-as failure and texture-permission failure.
indra/newview/skins/default/xui/en/floater_adjust_environment.xml	Adds the “Save As” button and supporting localized strings used by the new logic.
indra/newview/llfloaterenvironmentadjust.h	Declares the new onButtonSaveAs() handler.
indra/newview/llfloaterenvironmentadjust.cpp	Wires the new button callback and implements save-as logic (clone, validate, prompt, create item, open inventory).
indra/newview/llfloatereditenvironmentbase.cpp	Reuses the new failure notification on an existing save-as failure path.

Suppressed comments (1)

indra/newview/llfloaterenvironmentadjust.cpp:304

• Spelling in the TODO: “gracefull” -> “graceful”.

        // TODO: find a gracefull way to move these ids (and water ones) into get_can_copy_texture
        // as pickers should permit these textures by default to be able to work well with settings.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Geenz]

So one of the bigger worries with doing this one is just ensuring there's some level of protections to prevent someone from ripping a sky into their inventory that they don't have perms on. I'd look for some options to better bolster that.

[akleshchev]

@Geenz it already has image verification, if that is not enoug I can potentially only enable the button on the regions with permissions or default skies?