#5994 Fix path based launch for LLProcess - #6145
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restores prior behavior for LLProcess when launching an executable specified by name only (no directory component), ensuring it can be resolved via the environment PATH after the Boost.Process v2 migration.
Changes:
- Resolve bare executable names through
PATHusingbp::environment::find_executable()before launching. - Add a new unit test that launches the configured Python interpreter by basename to exercise PATH-based resolution.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| indra/llcommon/llprocess.cpp | Adds PATH-based resolution for executables with no parent path before process creation. |
| indra/llcommon/tests/llprocess_test.cpp | Adds a regression test validating PATH-based executable name resolution. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
akleshchev
force-pushed
the
andreyk/viewer_process_5994
branch
from
August 17, 2026 22:43
647966c to
bd3d104
Compare
marchcat
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An oversight with new boost implementation, for parity it should have been able to look for executable in PATH.