Conversation
|
site/src/App/HeadingOverride.css.ts
Outdated
There was a problem hiding this comment.
Let's delete this file for now and revert back to the existing h2 styles.
I'll address the styling of these headings as part of a followup with the 'Jump to' feature by creating a new CategoryHeading component given it's used in that menu as well
| Build the ToC sections | ||
| - Accessibility | ||
| - Each docSection and their children | ||
| - Accessibility (top-level when no bestPractices section, otherwise nested within it) |
There was a problem hiding this comment.
With this change we're reordering where accessibility sits within the docs. Previously we were treating accessibility as high-importance by consistently elevating it to the second item on the page.
I feel like we should retain that pattern, but open to discussion. Thoughts @michaeltaranto ?
There was a problem hiding this comment.
Happy to revert if we think that's best. Just worth noting, if we do 'Accessibility' will be the only section not assigned to a docSection. Maybe it's okay tho given it would be at the top of the page before any other H2
There was a problem hiding this comment.
I've reverted the change so 'Accessibility' renders at the top again 😎 @SEEKilian
| <Stack space="large"> | ||
| <Heading level="4">Critical</Heading> | ||
| <Text> | ||
| For destructive actions like “Delete” you can set the |
There was a problem hiding this comment.
These quotations should be replace with HTML entities
Also present on the following line is an ’ where an ' should be used.
| <TextLink href="/components/Heading">Heading</TextLink> element | ||
| using an <TextLink href="/components/Inline">Inline</TextLink>, | ||
| even though the button is actually taller than the heading. If we | ||
| didn’t use the <Strong>bleed</Strong> prop in this case, the |
There was a problem hiding this comment.
This ’ should be replace with an '
2 participants
Primary changes are:
docSectionsto Accordion, Badge and Button docs and removed the oldadditionalarrayUsagesection toBest practicesAccessibilityandAlternativesto sit underBest practicesHeading level=2to land on the look and feel