[codex] Fix CLI imports for non-editable installs#148
Merged
Conversation
1c5ecb1 to
09c9434
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the normal
pip installCLI failure wherefactlog.cliimported modules from the repository-leveltools/directory that is not included in installed package output.Changes
factlog/package:config,common,literal_types, andcompile_facts.factlog.clito import package modules and recompile accepted facts viapython -m factlog.compile_facts.tools/*.pydirect import/execution paths working through compatibility wrappers.python -m factlog doctorand thefactlog doctorconsole script outside the source tree.Root Cause
Editable installs kept the source-tree
tools/directory importable, masking that regular installs only packagefactlog/. As a result, installed CLI startup failed before reaching command logic withModuleNotFoundError: No module named 'factlog_config'.\n\n## Validation\n\n-bash tests/test_pip_install_cli.sh\n-bash tests/test_active_kb_config.sh\n-bash tests/test_amend.sh\n-bash tests/test_review.sh\n-bash tests/test_eject_cmd.sh\n-FACTLOG_ROOT=examples/sample-kb bash tests/golden.sh\n-python3 -m compileall -q factlog tools\n\nCloses #143