Expose graph-local fact readiness status#314
Merged
Merged
Conversation
Fact graph replay can partially fail without making the daemon unavailable, so readiness needs a cached subsystem view and a detail endpoint that reports graph-local state without exposing storage paths or raw storage errors. Constraint: preserve existing /healthz, text /readyz, and wyctl readiness behavior while adding JSON subsystem fields. Rejected: probing fact stores during every readiness request | cached replay results avoid status endpoints becoming storage work. Confidence: high Scope-risk: moderate Directive: keep fact graph replay failures graph-local unless startup cannot open the configured fact root. Tested: meson test -C builddir-issue50-fact --print-errorlogs; meson test -C builddir-issue50-default --print-errorlogs; meson test -C builddir-ci-pr daemon-http-decide daemon-http-decide-audit wyctl-policy-daemon wyctl-basic wyrelogd-healthz wyctl-status-daemon --print-errorlogs. Not-tested: Windows/macOS local runs. Co-authored-by: OmX <omx@oh-my-codex.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/readyz?format=json/facts/statusfor redacted tenant/graph readiness detailswyctl status --readinesscompatible with extra readiness JSON fieldsValidation
meson test -C builddir-issue50-fact --print-errorlogsmeson test -C builddir-issue50-default --print-errorlogsmeson test -C builddir-ci-pr daemon-http-decide daemon-http-decide-audit wyctl-policy-daemon wyctl-basic wyrelogd-healthz wyctl-status-daemon --print-errorlogs