[codex] Resolve Meson wrap fallback policy for wirelog#338
Merged
Conversation
5d92974 to
33bdd56
Compare
33bdd56 to
07fd9b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wirelog >= 0.50.0andlibchronoid >= 1.0.2before using Meson wraps.nofallback,forcefallback, andforce_fallback_foreven though the upstream subprojects do not export Meson fallback dependency variables.wirelogwrap fallback tov0.50.0.nanoarrowandxxhashredirect wraps as untracked Meson leftovers only when they point intowirelog/subprojects, since those dependencies are owned bywirelog.Closes #337
Validation
tools/check-supply-chain-pins.sh .WYL_SUPPLY_CHAIN_REQUIRE_PACKAGECACHE=1 tools/check-supply-chain-pins.sh .fails as expected on pre-existing missing DuckDB packagecache archives.meson setup build-system --wrap-mode=nofallback -Denable_audit=disabled -Denable_fact_store=disabledmeson compile -C build-systemmeson test -C build-system --print-errorlogs-> 70 OK, 0 failed, 2 skippedmeson setup build-fallback --wrap-mode=forcefallback -Denable_audit=disabled -Denable_fact_store=disabledsubprojects/wirelogchecked outv0.50.0meson compile -C build-fallback wyrelog/wyctl07fd9b2passed for Ubuntu, macOS, and Windows.