Conversation
check-vpc-nameservers.rb would fail with the following error when
attempting to validate the VPC nameservers on the DHCP option set:
Check failed to run: undefined method `each_value' for
#<Aws::EC2::Types::DhcpConfiguration:0x00556320a7a318>
This corrects the iterator so that that sensu check works as expected.
Member
check-vpc-nameservers.rb would fail with the following error when
attempting to validate the VPC nameservers on the DHCP option set:
Check failed to run: undefined method `each_value' for
#<Aws::EC2::Types::DhcpConfiguration:0x00556320a7a318>
This corrects the iterator so that that sensu check works as expected.
Contributor
Author
|
@majormoses: I created a new PR: #324 that is rebased off of master. I also added an entry to the CHANGELOG. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check-vpc-nameservers.rb would fail with the following error when
attempting to validate the VPC nameservers on the DHCP option set:
This corrects the iterator so that that sensu check works as expected.
Pull Request Checklist
Is this in reference to an existing issue?
General
Update Changelog following the conventions laid out here
Update README with any necessary configuration snippets
Binstubs are created if needed
RuboCop passes
Existing tests pass
New Plugins
Tests
Add the plugin to the README
Does it have a complete header as outlined here
Purpose
Known Compatibility Issues