Skip to content

properly iterate over IPs in check-vpc-nameservers.rb - #314

Closed
masneyb wants to merge 5 commits into
sensu-plugins:masterfrom
masneyb:master
Closed

masneyb wants to merge 5 commits into
sensu-plugins:masterfrom
masneyb:master

Conversation

@masneyb

@masneyb masneyb commented Dec 20, 2018

Copy link
Copy Markdown
Contributor

check-vpc-nameservers.rb would fail with the following error when
attempting to validate the VPC nameservers on the DHCP option set:

Check failed to run: undefined method `each_value' for
#<Aws::EC2::Types::DhcpConfiguration:0x00556320a7a318>

This corrects the iterator so that that sensu check works as expected.

Pull Request Checklist

Is this in reference to an existing issue?

General

  • Update Changelog following the conventions laid out here

  • Update README with any necessary configuration snippets

  • Binstubs are created if needed

  • RuboCop passes

  • Existing tests pass

New Plugins

  • Tests

  • Add the plugin to the README

  • Does it have a complete header as outlined here

Purpose

Known Compatibility Issues

masneyb and others added 3 commits December 20, 2018 18:21
check-vpc-nameservers.rb would fail with the following error when
attempting to validate the VPC nameservers on the DHCP option set:

    Check failed to run: undefined method `each_value' for
    #<Aws::EC2::Types::DhcpConfiguration:0x00556320a7a318>

This corrects the iterator so that that sensu check works as expected.
@majormoses

Copy link
Copy Markdown
Member

@masneyb sorry for the delayed response, can you please rebase against master as #322 will fix the CI issue you are seeing.

check-vpc-nameservers.rb would fail with the following error when
attempting to validate the VPC nameservers on the DHCP option set:

    Check failed to run: undefined method `each_value' for
    #<Aws::EC2::Types::DhcpConfiguration:0x00556320a7a318>

This corrects the iterator so that that sensu check works as expected.
@masneyb masneyb closed this Feb 19, 2019
@masneyb

masneyb commented Feb 19, 2019

Copy link
Copy Markdown
Contributor Author

@majormoses: I created a new PR: #324 that is rebased off of master. I also added an entry to the CHANGELOG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants