feat(io): accept pathlib.Path objects in IO tasks#807
Open
Pranava-Kumar wants to merge 1 commit into
Open
Conversation
Update VectorImportTask, ExportToTiffTask, and ImportFromTiffTask to accept pathlib.Path objects in addition to strings. The underlying get_base_filesystem_and_path utility already supports Path conversion; this change updates the type annotations to reflect the actual accepted types. Adds test coverage for the Path handling path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update
VectorImportTask,ExportToTiffTask, andImportFromTiffTaskto properly acceptpathlib.Pathobjects in addition to strings for their file path parameters.Changes
eolearn/io/geometry_io.py: UpdatedVectorImportTask.pathtype fromstrtostr | os.PathLike, addedosimporteolearn/io/raster_io.py: UpdatedBaseRasterIoTask.path,ExportToTiffTask.path,ImportFromTiffTask.pathtypesTesting
get_base_filesystem_and_path()accepts Path objects and converts to str