Fix uncaught error in Thrown Error button - Fixes MOBILE-REACT-NATIVE-5#120
Draft
cursor[bot] wants to merge 1 commit intomasterfrom
Draft
Fix uncaught error in Thrown Error button - Fixes MOBILE-REACT-NATIVE-5#120cursor[bot] wants to merge 1 commit intomasterfrom
cursor[bot] wants to merge 1 commit intomasterfrom
Conversation
Wrap the intentionally thrown error in try-catch block and properly capture it with Sentry.captureException() to prevent app crashes while still demonstrating error reporting functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the uncaught error being thrown from the "Uncaught Thrown Error" button in the ListApp screen.
Changes
Sentry.captureException()call to properly capture the errorIssue
Fixes MOBILE-REACT-NATIVE-5
Root Cause
The error was being thrown directly in the
onPresshandler without any error handling, causing an uncaught exception that propagated through React Native's event system.Solution
By wrapping the error throw in a try-catch block and explicitly capturing it with
Sentry.captureException(), we maintain the demonstration functionality while preventing the app crash.