Keep game running when errors occurred while rendering a skin object - #192
Open
Catizard wants to merge 1 commit into
Open
Keep game running when errors occurred while rendering a skin object#192Catizard wants to merge 1 commit into
Catizard wants to merge 1 commit into
Conversation
… rendering a skin object
seraxis
reviewed
Feb 23, 2026
| <VBox prefHeight="200.0" prefWidth="100.0" AnchorPane.bottomAnchor="0.0" AnchorPane.leftAnchor="0.0" AnchorPane.rightAnchor="0.0" AnchorPane.topAnchor="0.0"> | ||
| <CheckBox fx:id="usecim" mnemonicParsing="false" prefHeight="25.0" text="%CACHE_SKIN_IMAGE" /> | ||
| <CheckBox fx:id="clipboardScreenshot" mnemonicParsing="false" prefHeight="25.0" text="%CLIPBOARD_SCREENSHOT" /> | ||
| <CheckBox fx:id="keepSilentWhenRenderFailed" mnemonicParsing="false" prefHeight="25.0" text="%IGNORE_SKIN_OBJECT_RENDER_ERROR" /> |
Owner
There was a problem hiding this comment.
I feel like finding space on the top bar in the Skin tab might be more appropriate for this one? or should this feature always be on, I'm not sure what value we bring to the user by allowing skin failures to be fatal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr adds a new configurable option in
othertab, which allows the game keeps running even there's an unexpected error happening from rendering some skin objects. Aiming to improve the making process of skins.It notifies the user when error occurs:
And can be viewed in widget menu after(highlighted as red):