Migrate from jbmstable-parser to kbmstable-parser - #198
Draft
Catizard wants to merge 1 commit into
Draft
Conversation
Catizard
marked this pull request as draft
January 5, 2026 05:17
Catizard
force-pushed
the
refactor/move_kbmstable_parser
branch
from
January 26, 2026 07:19
f6da96d to
605da5a
Compare
BKVad1m
reviewed
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a radical proposal: remove the jbmstable-parser dependency with kbmstable-parser
Pros:
Cons:
Compatibility issue
There're two fields that used by ED but completed removed in kbmstable-parser: one is
modeand one isparentHash. Themodefield is indicating what this table's play mode is: 7k/9k/5k. TheparentHashis only used inipfsdownload feature and no documentation about it.