Skip to content

Migrate from jbmstable-parser to kbmstable-parser - #198

Draft
Catizard wants to merge 1 commit into
seraxis:mainfrom
Catizard:refactor/move_kbmstable_parser
Draft

Migrate from jbmstable-parser to kbmstable-parser#198
Catizard wants to merge 1 commit into
seraxis:mainfrom
Catizard:refactor/move_kbmstable_parser

Conversation

@Catizard

Copy link
Copy Markdown
Collaborator

This is a radical proposal: remove the jbmstable-parser dependency with kbmstable-parser

Pros:

  • It has a more concise, clean code base. Old designs and some of the old fields are abandoned.
  • It's slightly faster

Cons:

  • I cannot make sure it can provide 100% compatibility to all existing difficult tables, see here for what tables are tested

How does this project been tested?

It runs a "clap test": for each difficult table, comparing the parse result from kbmstable-parser and jbmstable-parser and make sure they're identical.

Compatibility issue

There're two fields that used by ED but completed removed in kbmstable-parser: one is mode and one is parentHash. The mode field is indicating what this table's play mode is: 7k/9k/5k. The parentHash is only used in ipfs download feature and no documentation about it.

@Catizard
Catizard marked this pull request as draft January 5, 2026 05:17
@Catizard
Catizard force-pushed the refactor/move_kbmstable_parser branch from f6da96d to 605da5a Compare January 26, 2026 07:19
Comment thread core/src/bms/player/beatoraja/TableDataAccessor.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants