Fix shader not working on macos - #226
Open
Catizard wants to merge 1 commit into
Open
Conversation
Chazoshtare
reviewed
Feb 26, 2026
Catizard
force-pushed
the
fix/shader_wont_work
branch
from
February 26, 2026 12:33
cc4ff8b to
6f3a2e2
Compare
Collaborator
Author
|
After looking into the issues pointed in #210, I found none of them would be fixed in this pr although they seems to be rather related to the problem solved in this pr. Especially the transparent colors are still broken after the changes based on the fact that they are looking fine on my test application. |
Catizard
force-pushed
the
fix/shader_wont_work
branch
from
March 9, 2026 12:40
6f3a2e2 to
422101d
Compare
Catizard
force-pushed
the
fix/shader_wont_work
branch
from
March 17, 2026 09:51
422101d to
05bdb91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr is demanding volunteers for testing on linux and widnows.
This pr aims to fix the issue that shander doesn't work on macos, and properly, linux. The initial problem is some old bms, e.g. gengaozo, is using an old trick which is so called "black color keying" to mimic the "transparent color". In beatoraja, this is achieved by using a shader. However, the shader file is using the old standard that simply won't compile on macos and linux. Causing gengaozo's bga looks funny and has crazy flashes that can burn ppl eyes.
In this pr, I rerouted the shader files to _unix variant if os is mac or linux.
For more information, please check out https://hitkey.bms.ms/cmds.htm#BMPXX-LAYER.
This pr has a high possibility is related to #210, I haven't looked into it yet