Hide the override download url feature - #260
Open
Catizard wants to merge 1 commit into
Open
Conversation
This commit cuts the configurable option `overrideDownloadURL` from launcher. This will make it: - Unconfigurable - No longer takes effect This reason I coded this feature was because `wriggle` is designed to serve a 'direct' download endpoint, compared to what `ginger` and `konmai` does: they require client to "ask if the package was presenting on the server" before "giving the direct download link back". As wriggle was the only download source we can use before, such a feature that allows you tweak the download source is good enough to adapt the issues like server domain changes. No need to say it actually happens a serveral times. However, such a design cannot be used on `ginger` and `konmai` because they require client to ask before downloading, and the response data structure from server varies. Also this feature is more hard to understand for casual users, we have seen how many times this misleads the users trying to use this feature to switch to `konmai` or `ginger`. As mentioned before, this design is not capable with these servers. So in this commit it's getting removed, but not entirely: some of the inner implementation is preserved. This is trying to not make a big change instantly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit cuts the configurable option
overrideDownloadURLfrom launcher. This will make it:This reason I coded this feature was because
wriggleis designed to serve a 'direct' download endpoint, compared to whatgingerandkonmaidoes: they require client to "ask if the package was presenting on the server" before "giving the direct download link back". As wriggle was the only download source we can use before, such a feature that allows you tweak the download source is good enough to adapt the issues like server domain changes. No need to say it actually happens a serveral times.However, such a design cannot be used on
gingerandkonmaibecause they require client to ask before downloading, and the response data structure from server varies. Also this feature is more hard to understand for casual users, we have seen how many times this misleads the users trying to use this feature to switch tokonmaiorginger. As mentioned before, this design is not capable with these servers.So in this commit it's getting removed, but not entirely: some of the inner implementation is preserved. This is trying to not make a big change instantly.