Support withCredentials in useEventSource()#229
Open
kensnyder wants to merge 1 commit intosergiodxa:mainfrom
Open
Support withCredentials in useEventSource()#229kensnyder wants to merge 1 commit intosergiodxa:mainfrom
kensnyder wants to merge 1 commit intosergiodxa:mainfrom
Conversation
|
@sergiodxa It'll be nice to have this merged or are there any issues with it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you pass an object as init the hook will call open and immediately close every render because the init object is a by-reference dependency of the useEffect. MDN currently only documents one possible option: withCredentials: boolean;.
In this PR I just handle withCredentials specially. An alternative would be to just remove init from the dependency array because changing it after creating the EventSource doesn't make sense. Another possible solution is to use JSON.stringify() outside the useEffect and JSON.parse() inside the useEffect.