jsglue: add a method to retrieve ErrorInfo from the pending exception stack#723
Open
Gae24 wants to merge 1 commit intoservo:mainfrom
Open
jsglue: add a method to retrieve ErrorInfo from the pending exception stack#723Gae24 wants to merge 1 commit intoservo:mainfrom
Gae24 wants to merge 1 commit intoservo:mainfrom
Conversation
Taym95
reviewed
Mar 23, 2026
| cx, | ||
| message_buf.as_mut_ptr(), | ||
| filename_buf.as_mut_ptr(), | ||
| 1024, |
Gae24
force-pushed
the
exception-stack
branch
7 times, most recently
from
eaa132f to
a0c40b2
Compare
Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>
sagudev
reviewed
Apr 12, 2026
| if (!message) { | ||
| message = builder.toStringResult().c_str(); | ||
| } | ||
| *message_len = std::min<size_t>(1024, strlen(message)); |
Member
There was a problem hiding this comment.
I think this might reasonable strategy for filename, but not for message. Also we are doing two copies, one to message_buffer and one with to_string. Maybe we should impl this with callbacks, that receive len and char* and create rust string from it.
We might also skip utf8 validation if I understand https://searchfox.org/firefox-main/source/js/public/CharacterEncoding.h#135 correctly.
Contributor
Author
There was a problem hiding this comment.
Sorry could you expand on it? Is the issue that the selected length could be insufficient?
Member
There was a problem hiding this comment.
Yes and the fact that implementation is not optimal we copy it twice, firstly into rust array then into rust String.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to retrieve
ErrorInfofrom the stack of the pending exception, to avoid empty messages on uncaught exceptions.Testing: Need to test it with servo.
Servo PR: servo/43632