Remove duplicate eglDestroyContext call in angle Device::destroy_context#365
Merged
Conversation
…ontext` It's quite likely that this duplicate `eglDestroyContext` call is causing the Windows CI to hang. This change removes the duplicate call to context destruction. Signed-off-by: Martin Robinson <mrobinson@abandonedwig.info>
Member
Author
|
The CI still seems to be hanging, but this is still a good fix, I think. |
jdm
approved these changes
Jun 7, 2026
jdm
left a comment
jdm
left a comment
Member
There was a problem hiding this comment.
Super weird this was here at all!
Member
Author
Agreed. I tracked this down to the initial implementation, so I suspect it was just a copy-and-paste issue or something along those lines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's quite likely that this duplicate
eglDestroyContextcall iscausing the Windows CI to hang. This change removes the duplicate call
to context destruction.