Run tests with cargo-nextest#367
Merged
Merged
Conversation
dc78494 to
5bd75be
Compare
This is a speculative fix to try to make test runs more reliable. The inspiration here is wgpu which also uses `cargo-nextest` to run tests. This will isolate each test by process, which should help to avoid interference between them. Signed-off-by: Martin Robinson <martin@abandonedwig.info>
5bd75be to
0e54f41
Compare
jdm
approved these changes
Jun 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a speculative fix to try to make test runs more reliable. The
inspiration here is wgpu which also uses
cargo-nextestto run tests.This will isolate each test by process, which should help to avoid
interference between them.
As part of this change, we also need to fix an issue in one of the tests
where a worker thread can outlive the test that spawned it. The fix
is to wait until the worker thread joins the main thread before finishing
the test, otherwise it will cause an error in test execution.