fix: pydantic error in accent_marker and imporve logging - #37
Merged
Conversation
fix: fix reading from yahoo_subword heap: adjustment yahoo_subword's type hint chore: change furigana_results's data type
minto1226
changed the title
minto1226
force-pushed
the
fix/number-marker
branch
3 times, most recently
from
December 12, 2025 14:36
f85747f to
ef26227
Compare
heat: fix httpx problem chore: fix ruff problem chore: fix ruff problem chore: fix ruff problem
minto1226
force-pushed
the
fix/number-marker
branch
from
December 12, 2025 14:59
f019325 to
71b5203
Compare
wade00754
previously approved these changes
Dec 13, 2025
wade00754
left a comment
wade00754
left a comment
Member
There was a problem hiding this comment.
Approved. But please take the recommendations into consideration.
minto1226
force-pushed
the
fix/number-marker
branch
2 times, most recently
from
December 14, 2025 07:32
82bdd64 to
95d06fd
Compare
chore: change print to logger fix: fix ruff problem fix: fix ruff problem fix: fix ruff problem
minto1226
force-pushed
the
fix/number-marker
branch
from
December 14, 2025 07:32
95d06fd to
122cfa4
Compare
chore: change print to logger
minto1226
force-pushed
the
fix/number-marker
branch
from
December 14, 2025 07:36
cd27cee to
6ac1e08
Compare
wade00754
requested changes
Dec 15, 2025
wade00754
left a comment
wade00754
left a comment
Member
There was a problem hiding this comment.
Please take a look at the comments to do futher changes.
wade00754
reviewed
Dec 15, 2025
minto1226
force-pushed
the
fix/number-marker
branch
from
December 19, 2025 00:45
27c8ba1 to
36b9320
Compare
wade00754
changed the title
wade00754
changed the title
🛡️ PR Quality Check Summary✅ PR Title: Passed (Length: 56/75, Format: OK). 🎉 All checks passed! |
wade00754
approved these changes
Dec 25, 2025
wade00754
left a comment
wade00754
left a comment
Member
There was a problem hiding this comment.
I have found that FastAPI can use the Pydantic model as respone so that we can return it directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
目的
修改
furigana_results至正確的datatype，以及修改print成logger方法／實作說明
mark_furigana()改為直接returnResponseobject.關聯 Issue
fix #36