Add id to filter forms for LiveView form recovery - #190
Merged
Conversation
Owner
|
Nice one, thank you so much for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The filter control forms in
Cinder.FilterManagerusephx-change/phx-submitbut have noidattribute. LiveView requires formids to perform form recovery following crashes or disconnects.Apps that enable the strict LiveView test check:
get a runtime error for every Cinder table that renders filters:
Fix
Add an
idderived from the existing@table_idassign to both filter forms (the slot-based and default render paths):#{@table_id}-filtersfor the controls-slot form#{@table_id}-filter-formfor the default formNotes
@table_idis already passed into these render functions and used for child element ids (e.g.#{@table_id}-filter-body), so the new ids are unique per table.