Add an optional sync loading mode - #203
Merged
Merged
Conversation
Contributor
Author
Screen.Recording.movHere is a simple demo, in the first half of the video the data hasn't been loaded yet, those a flash of empty table/loading state appears. In the second half, the collection items were already loaded so even if the websocket hasn't fully mounted yet, the data is available |
Owner
|
Heya, thanks for this! I'm going to merge this PR as is, but rename the option before release - |
Contributor
Author
|
Fair!! And thanks!! |
sevenseacat
added a commit
that referenced
this pull request
Aug 26, 2026
`ssr` named the outcome rather than the mechanism — Cinder's HTML is server-rendered either way, and what the flag changes is whether the data is in that first render. The global default is now `default_initial_load`, and an unrecognised mode warns instead of silently falling back. Also reverts #203's change to first-load detection, which made a failed load stick in its error state instead of retrying, for every collection rather than just synchronous ones. A synchronous first load only needs to gate the sync/async choice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a global and overridable per collection flag to allow the initial load to be synchronous, making it SSR. Added a few tests to ensure everything afterwards is still async and the user choices are respected. By default is disabled to make it completely opt-in