Skip to content

rename testEmptyLine to isEmptyLine and change the signature + add wa… - #21

Merged
severo merged 2 commits into
mainfrom
isEmptyLine
Nov 17, 2025
Merged

rename testEmptyLine to isEmptyLine and change the signature + add wa…#21
severo merged 2 commits into
mainfrom
isEmptyLine

Conversation

@severo

@severo severo commented Nov 17, 2025

Copy link
Copy Markdown
Owner

…rning in README about stability

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames the testEmptyLine function to isEmptyLine and improves its API by changing the signature from accepting a union type parameter to using an options object. The version is bumped to 0.0.6, and a versioning policy section is added to the README.

  • Renamed testEmptyLine to isEmptyLine for better naming consistency
  • Changed function signature from (s, skipEmptyLines?: 'greedy' | boolean) to (s, options?: { greedy?: boolean }) for improved API extensibility
  • Added versioning policy section to README documenting breaking change expectations

Reviewed Changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/utils.ts Updated function name and signature with options object pattern
src/index.ts Exported the renamed isEmptyLine function
src/options/delimiter.ts Updated function call to use new isEmptyLine name
tests/utils.test.ts Updated tests to use new function name and options object
tests/text.test.ts Updated test cases to use new function name and options syntax
package.json Bumped version from 0.0.5 to 0.0.6
package-lock.json Updated version reference to 0.0.6
README.md Added "Early version" section with versioning policy
CHANGELOG.md Added entry for version 0.0.6 documenting the changes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/utils.ts Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@severo
severo merged commit 5057522 into main Nov 17, 2025
5 checks passed
@severo
severo deleted the isEmptyLine branch November 17, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants