security: P1 audit logging, consent verification, and PII filtering #5
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| /** | ||
| * Filter Toss Payments API response to retain only non-PII fields. | ||
| * Raw responses may contain card numbers, buyer name, phone, etc. | ||
| */ | ||
|
|
||
| const ALLOWED_FIELDS = [ | ||
| "paymentKey", | ||
| "orderId", | ||
| "orderName", | ||
| "status", | ||
| "method", | ||
| "type", | ||
| "approvedAt", | ||
| "requestedAt", | ||
| "totalAmount", | ||
| "suppliedAmount", | ||
| "vat", | ||
| "currency", | ||
| "receiptUrl", | ||
| ] as const; | ||
|
|
||
| export function sanitizeTossResponse( | ||
| response: Record<string, unknown> | ||
| ): Record<string, unknown> { | ||
| const sanitized: Record<string, unknown> = {}; | ||
|
|
||
| for (const key of ALLOWED_FIELDS) { | ||
| if (key in response) { | ||
| sanitized[key] = response[key]; | ||
| } | ||
| } | ||
|
|
||
| return sanitized; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,50 @@ | ||||||
| import { headers } from "next/headers"; | ||||||
| import { createAdminClient } from "@/shared/api/supabase/admin"; | ||||||
|
|
||||||
| type AuditAction = | ||||||
| | "file.upload" | ||||||
| | "file.download" | ||||||
| | "analysis.create" | ||||||
| | "analysis.delete" | ||||||
| | "report.download" | ||||||
| | "payment.confirm" | ||||||
| | "account.delete"; | ||||||
|
|
||||||
| type ResourceType = "analysis" | "payment" | "report" | "account"; | ||||||
|
|
||||||
| interface AuditLogParams { | ||||||
| userId: string; | ||||||
| action: AuditAction; | ||||||
| resourceType: ResourceType; | ||||||
| resourceId?: string; | ||||||
| metadata?: Record<string, unknown>; | ||||||
| } | ||||||
|
|
||||||
| export async function logAudit({ | ||||||
| userId, | ||||||
| action, | ||||||
| resourceType, | ||||||
| resourceId, | ||||||
| metadata, | ||||||
| }: AuditLogParams): Promise<void> { | ||||||
| try { | ||||||
| const headerStore = await headers(); | ||||||
|
There was a problem hiding this comment. The
Suggested change
|
||||||
| const ipAddress = | ||||||
| headerStore.get("x-forwarded-for")?.split(",")[0]?.trim() ?? null; | ||||||
| const userAgent = headerStore.get("user-agent") ?? null; | ||||||
|
|
||||||
| const admin = createAdminClient(); | ||||||
| await admin.from("audit_logs").insert({ | ||||||
| user_id: userId, | ||||||
| action, | ||||||
| resource_type: resourceType, | ||||||
| resource_id: resourceId ?? null, | ||||||
| ip_address: ipAddress, | ||||||
| user_agent: userAgent, | ||||||
| metadata: metadata ?? {}, | ||||||
| }); | ||||||
| } catch (error) { | ||||||
| // Audit logging should never break the main request | ||||||
| console.error("Audit log failed:", error); | ||||||
| } | ||||||
| } | ||||||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
AuditActiontype is missing the'analysis.auto_delete'action, which is used in thecleanup_expired_analysesSQL function. To maintain consistency between the database and the TypeScript types, please add it to the union type. This will be helpful for any future code that might process audit logs.