Add command line option for separate debug info#7255
Add command line option for separate debug info#7255jarcherNV wants to merge 7 commits intoshader-slang:masterfrom
Conversation
|
This is an alternative to #7178 Note that unlike 7178, this PR does not work for two reasons:
Edit: I have fixed the problem from (2), but we will still need the upstream fix for (1). |
jarcherNV
force-pushed
the
jarcher-dev-isseu-7098-alt
branch
from
dc7f9db to
963afcc
Compare
jarcherNV
force-pushed
the
jarcher-dev-isseu-7098-alt
branch
from
963afcc to
c5d27d1
Compare
Add command line arg -separate-debug-info which, if provided, produces both a .spv and a .dbg.spv file. The .dbg.spv file contains full debug info and the .spv file has all debug info stripped out. This patch also updates external/spirv-tools to point at the slang fork which has a patch needed for this to work. We will change this back when the patch is upstreamed.
jarcherNV
force-pushed
the
jarcher-dev-isseu-7098-alt
branch
from
c5d27d1 to
328dec2
Compare
|
I have updated the patch to point spirv-tools at the Slang fork, which has the needed fix for this to work. We will need to change this back once the patch is upstreamed (assuming all the tests pass). |
|
/format |
|
🌈 Formatted, please merge the changes from this PR |
…8-alt Format code for PR shader-slang#7255
|
/regenerate-cmdline-ref |
|
🌈 Regenerated command line reference, please merge the changes from this PR |
…er-dev-isseu-7098-alt Regenerate command line reference for PR shader-slang#7255
|
After some recent discussion with Aftermath team it sounds like we may want to use the #7178 PR instead. I will leave this open for now in case we change our minds, but likely to close without submitting. |
|
We should also consider adding a unit test to look for the debug identifier in the spirv that has the debug info. |
|
We have decided not to use this approach so I am closing this PR. |
3 participants
Add command line arg -separate-debug-info which, if provided, produces both a .spv and a .dbg.spv file. The .dbg.spv file contains full debug info and the .spv file has all debug info stripped out.