Bugfix: Simplify BTRFS checks and improve useradd behavior for non-BTRFS#1614
Merged
alejandro-colomar merged 5 commits intoshadow-maint:masterfrom Apr 23, 2026
Merged
Bugfix: Simplify BTRFS checks and improve useradd behavior for non-BTRFS#1614alejandro-colomar merged 5 commits intoshadow-maint:masterfrom
alejandro-colomar merged 5 commits intoshadow-maint:masterfrom
Conversation
Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar
force-pushed
the
master
branch
from
15da88f to
4083ee2
Compare
This simplifies the return value of is_btrfs() into a boolean. Signed-off-by: Alejandro Colomar <alx@kernel.org>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
When the --btrfs-subvolume-home option is used but the parent directory is not on a BTRFS filesystem, useradd previously failed with an error. This is too strict; instead, fall back to creating a regular directory and issue a warning. The subvolume creation is attempted only when the parent is BTRFS. Otherwise, a regular directory is created and a syslog(3) warning is logged. Fixes: 3e8c105 (2026-01-02; "src/useradd: Support config for creating home dirs as Btrfs subvolumes") Co-authored-by: Hadi Chokr <hadichokr@icloud.com> Co-authored-by: Alejandro Colomar <alx@kernel.org> Signed-off-by: Alejandro Colomar <alx@kernel.org>
Signed-off-by: Hadi Chokr <hadichokr@icloud.com> Reviewed-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar
force-pushed
the
master
branch
from
4083ee2 to
e681ab2
Compare
Collaborator
Cc: @Conan-Kudo |
ikerexxe
approved these changes
Apr 23, 2026
Collaborator
ikerexxe
left a comment
ikerexxe
left a comment
There was a problem hiding this comment.
This is a significant improvement over the previous versions. Thank you for the great effort here!
alejandro-colomar
approved these changes
Apr 23, 2026
Contributor
|
@ikerexxe can we get this backported into Fedora please? |
Collaborator
|
@Conan-Kudo this is for fedora rawhide https://bodhi.fedoraproject.org/updates/FEDORA-2026-2ad058a479. Do you also expect it in fedora 44? |
Contributor
|
Yes, please, if you can. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.