tests: improve cloud environment compatibility#1615
Open
ikerexxe wants to merge 7 commits intoshadow-maint:masterfrom
Open
tests: improve cloud environment compatibility#1615ikerexxe wants to merge 7 commits intoshadow-maint:masterfrom
ikerexxe wants to merge 7 commits intoshadow-maint:masterfrom
Conversation
hallyn
approved these changes
Apr 24, 2026
Member
hallyn
left a comment
hallyn
left a comment
There was a problem hiding this comment.
LGTM, except, as I said out of band, I think it might be more robust to have the ansible jobs which create the ci user check which uids are in use. But it's not critical, can wait for later, no objection to merging this.
…ount point Handle cases where /home is mounted separately by using selective cleanup instead of attempting to remove the mount point, which causes "Device or resource busy" errors in cloud environments. Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Create a 'ci' user in all distribution-specific ansible roles to simulate cloud VM environments where ID 1000 is already taken. This ensures that test users start the ID assignment at 1001, making container tests consistent with cloud CI environments. Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Update test assertions to expect ID 1001 instead of 1000 to match the new container environment where a CI user occupies ID 1000. Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Update test assertions to expect GID 1001 instead of 1000 to match the new container environment where a CI user occupies ID 1000. Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Update test assertions to expect ID 1001 instead of 1000 to match the new container environment where a CI user occupies ID 1000. Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Update test assertions to expect ID 1001 instead of 1000 to match the new container environment where a CI user occupies ID 1000. Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Update test assertion to expect GID 1002 instead of 1001 to match the new container environment where a CI user occupies ID 1000. Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
ikerexxe
force-pushed
the
test-fedora-ci
branch
from
58bc953 to
6cfb9a2
Compare
Collaborator
Author
Updated to take this into account. Take a look when you have a moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enhances the system tests to work reliably in cloud VM environments by addressing two main compatibility issues:
/homedirectory restoration when/homeis a separate mount point.ubuntuorec2-user).Fixes:
/homecleanup instead of attempting to remove mounted directories.