Supersede #906: entry shape test with lint-compliant matcher

[justin808]

Supersedes #906. Closes #792.

Summary

• carry forward the entry-shape regression test from Add entry shape regression test for type narrowing #906
• fix ESLint jest/prefer-strict-equal by using toStrictEqual for the matcher assertion

Validation

• yarn test test/package/environments/base.test.js
• yarn eslint test/package/environments/base.test.js --max-warnings 0

Notes

• This PR does not add commits to Add entry shape regression test for type narrowing #906's existing branch.

[coderabbitai]

Warning

Rate limit exceeded

@justin808 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 14 minutes and 4 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch codex/supersede-906-entry-shape

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[greptile-apps]

Greptile Summary

This PR adds a regression test that explicitly asserts the shape of webpack entry values produced by getEntryObject() in package/environments/base.ts. Single-file entries must be strings and multi-file entries must be arrays of strings — a contract that downstream TypeScript consumers rely on for type narrowing. The test uses toStrictEqual with expect.arrayContaining / expect.any(String) to satisfy the project's jest/prefer-strict-equal ESLint rule.

• Adds "keeps entry value shapes stable for TypeScript narrowing" test in test/package/environments/base.test.js
• Supersedes PR Add entry shape regression test for type narrowing #906 by switching from toEqual to toStrictEqual
• Closes issue Validate type narrowing for Entry type in base.ts #792

Confidence Score: 5/5

• This PR is safe to merge — it only adds a new test case with no production code changes.
• The change is a single, well-scoped test addition (11 lines) that uses established Jest patterns and complies with the project's lint rules. No production code is modified. The assertions correctly validate the entry shapes documented in the source (package/environments/base.ts lines 50-86).
• No files require special attention.

Important Files Changed

Filename	Overview
test/package/environments/base.test.js	Adds a new test case that explicitly asserts entry value shapes (string for single-file entries, array of strings for multi-file entries). Uses toStrictEqual to comply with jest/prefer-strict-equal lint rule. No issues found.

Flowchart

flowchart TD
    A[getEntryObject in base.ts] -->|single file| B["entries[name] = assetPath\n(string)"]
    A -->|multiple files same name| C["entries[name] = [path1, path2]\n(string[])"]
    B --> D[New shape test]
    C --> D
    D -->|asserts| E["typeof application === 'string'"]
    D -->|asserts| F["Array.isArray(multi_entry) === true"]
    D -->|asserts| G["multi_entry contains String elements"]

Loading

_{Last reviewed commit: 25442b7}

[justin808]

Superseded by #919, which preserves the #910 test fix and adds the current lint-unblock commit.