Keep manual audio and subtitle choices within the current programme - #642
Draft
mechaigor-hash wants to merge 2 commits into
Draft
Keep manual audio and subtitle choices within the current programme#642mechaigor-hash wants to merge 2 commits into
mechaigor-hash wants to merge 2 commits into
Conversation
Owner
|
Starting review today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #641. This keeps remote-control audio/subtitle selections local to the currently playing scheduled programme block, so a viewer's manual choice survives bumpers/commercials and is cleared when the next programme starts.
Behaviour
AUDIO/SUBSbutton choices only while afeaturevideo is playingNotes
This is intentionally marked as a draft because it is stacked on top of #641. Until #641 is merged, GitHub will show both the remote-button commit and this follow-up commit in this PR.
Testing
Result: