Skip to content

Add MOM estimator options - #30

Merged
shenxiangzhuang merged 2 commits into
masterfrom
codex/add-mom-estimator
Jun 3, 2026
Merged

Add MOM estimator options#30
shenxiangzhuang merged 2 commits into
masterfrom
codex/add-mom-estimator

Conversation

@shenxiangzhuang

Copy link
Copy Markdown
Owner

Summary

  • add explicit SPOT estimator, initial threshold, and excess update options
  • keep SpotDetector::new defaulting to the existing Best/P2/>= behavior
  • add FluxEV-style MOM support using sample variance, empirical thresholding, and strict > excess updates
  • preserve serde compatibility for older SpotDetector JSON payloads

Validation

  • cargo fmt --check
  • cargo test --manifest-path crates/libspot-rs/Cargo.toml
  • cargo clippy --manifest-path crates/libspot-rs/Cargo.toml --all-targets -- -D warnings

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

▸ Cross-implementation results

commit 344786a · Linux · release builds

Consistency (basic example)

Metric C Rust FFI Pure Rust
Anomalies 90007 90007 90007
Excess 7829 7829 7829
Normal 49902164 49902164 49902164
Z 6.237668 6.237668 6.237668
T 6.236165 6.236165 6.236165

Benchmark (hyperfine --warmup 1 --runs 5)

Command Mean [s] Min [s] Max [s] Relative
raw C 1.004 ± 0.001 1.003 1.006 1.00
Rust FFI (libspot) 1.520 ± 0.001 1.518 1.522 1.51 ± 0.00
Pure Rust (libspot-rs) 1.215 ± 0.004 1.209 1.220 1.21 ± 0.00

updated by Test cross-implementation consistency

@shenxiangzhuang
shenxiangzhuang merged commit f438698 into master Jun 3, 2026
2 checks passed
@shenxiangzhuang
shenxiangzhuang deleted the codex/add-mom-estimator branch June 3, 2026 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant