Remove unused Ptr_xxx_get P/Invoke declarations from features2d NativeMethods - #1879
Merged
Merged
Conversation
…eMethods All feature detector Create() methods (SIFT, BRISK, ORB, MSER, FastFeatureDetector, AgastFeatureDetector, GFTTDetector, SimpleBlobDetector, KAZE, AKAZE) use the shared features2d_Ptr_Feature2D_get to retrieve the raw pointer. The individual Ptr_xxx_get declarations were added during #1846 but never called, and have no corresponding C++ implementation. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
📝 WalkthroughWalkthroughThis PR removes ten unused P/Invoke method declarations from the features2d native method bindings. The removed methods are pointer getter operations ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
4 tasks
This was referenced Jun 22, 2026
This was referenced Jul 6, 2026
This was referenced Jul 25, 2026
This was referenced Aug 10, 2026
This was referenced Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleanup of dead code found while investigating the #1846 migration.
All feature detector
Create()methods (SIFT, BRISK, ORB, MSER, FastFeatureDetector, AgastFeatureDetector, GFTTDetector, SimpleBlobDetector, KAZE, AKAZE) retrieve the raw pointer via the sharedfeatures2d_Ptr_Feature2D_get. The individualPtr_xxx_getdeclarations were added toNativeMethods_features2d_Feature2D.csduring #1846 but:features2d_Feature2D.hRemoves all 10 dead declarations.
Summary by CodeRabbit