Expose OpenCL platform and device information - #2112
Merged
Conversation
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThis PR adds OpenCL platform and device enumeration to the managed API. It introduces immutable snapshot types, native wrappers, P/Invoke declarations, managed conversion logic, and a test for available and unavailable OpenCL runtimes. ChangesOpenCL platform snapshot enumeration
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant Caller
participant Cv2.Ocl
participant NativeMethods
participant OpenCvSharpExtern
participant OpenCV OCL
Caller->>Cv2.Ocl: GetPlatformsInfo()
alt OpenCL unavailable
Cv2.Ocl-->>Caller: empty result
else OpenCL available
Cv2.Ocl->>NativeMethods: core_ocl_getPlatformsInfo()
NativeMethods->>OpenCvSharpExtern: get native platform vector
OpenCvSharpExtern->>OpenCV OCL: query platforms and devices
OpenCV OCL-->>OpenCvSharpExtern: platform/device metadata
OpenCvSharpExtern-->>NativeMethods: vector handle and indexed fields
NativeMethods-->>Cv2.Ocl: native values
Cv2.Ocl->>NativeMethods: vector size and indexed reads
Cv2.Ocl->>Cv2.Ocl: build OclPlatformInfo and OclDeviceInfo
Cv2.Ocl->>NativeMethods: core_ocl_PlatformInfoVector_delete()
Cv2.Ocl-->>Caller: IReadOnlyList<OclPlatformInfo>
end
Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cv2.Ocl.GetPlatformsInfo()as read-only platform and device snapshotsOclPlatformInfo,OclDeviceInfo, andOclDeviceTypesFollow-up to #2111.
Validation
cmake --build src\build --config Release --target OpenCvSharpExterndotnet build src\OpenCvSharp\OpenCvSharp.csproj -c Release --no-restoredotnet test test\OpenCvSharp.Tests\OpenCvSharp.Tests.csproj -c Release --no-restore --filter "FullyQualifiedName~OpenCvSharp.Tests.Core.OclTest"(3 passed)git diff --checkSummary by CodeRabbit