Drop --enable-libshaderc, removed from ffmpeg - #836
Open
JuliusBairaktaris wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Removes an obsolete FFmpeg configure flag (--enable-libshaderc) from the winbuild CMake packaging now that upstream FFmpeg no longer recognizes it, unblocking builds against FFmpeg master while keeping shaderc available for other dependencies (e.g., libplacebo).
Changes:
- Drop
--enable-libshadercfrom the FFmpegExternalProject_Add(... CONFIGURE_COMMAND ...)arguments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ffmpeg replaced the libshaderc dependency with a build-time probe for a
glslcorglslangValidatorbinary, so configure now aborts withUnknown option "--enable-libshaderc"and every build against master stops there.Removing the flag is enough; the shaderc package is still needed for libplacebo. Verified by configuring ffmpeg at 946272b79 in the gcc toolchain.