Skip to content

[main] fix: Run Shared Setup for Release#350

Merged
openshift-merge-bot[bot] merged 1 commit into
shipwright-io:mainfrom
adambkaplan:fix-golang-release
Sep 9, 2025
Merged

[main] fix: Run Shared Setup for Release#350
openshift-merge-bot[bot] merged 1 commit into
shipwright-io:mainfrom
adambkaplan:fix-golang-release

Conversation

@adambkaplan

Copy link
Copy Markdown
Member

Changes

Use the shared Setup action to install go and ko.

/kind bug

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

Fix release action to install common base version of compile tools.

Use the shared Setup action to install go and ko.

Signed-off-by: Adam Kaplan <adam.kaplan@redhat.com>
@pull-request-size pull-request-size Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 8, 2025
@openshift-ci openshift-ci Bot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 8, 2025

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2025
@openshift-ci

openshift-ci Bot commented Sep 9, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2025
@openshift-merge-bot
openshift-merge-bot Bot merged commit 5721f8a into shipwright-io:main Sep 9, 2025
11 checks passed
@github-project-automation github-project-automation Bot moved this to Done in Issues Sep 9, 2025
@adambkaplan
adambkaplan deleted the fix-golang-release branch September 9, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants