feat: add the create newsletter recipient request#648
Open
suri-ta777 wants to merge 8 commits into
Open
Conversation
commit: |
suri-ta777
changed the title
suri-ta777
changed the title
suri-ta777
force-pushed
the
test/add-checkout-with-promotion-discount-rule
branch
from
7eda74e to
cf5e02a
Compare
suri-ta777
force-pushed
the
test/add-checkout-with-promotion-discount-rule
branch
2 times, most recently
from
f224c4f to
017ed00
Compare
Stefan Guder (sguder)
requested changes
Jun 22, 2026
Stefan Guder (sguder)
requested changes
Jun 24, 2026
suri-ta777
force-pushed
the
test/add-checkout-with-promotion-discount-rule
branch
from
38ef4df to
318a28e
Compare
suri-ta777
changed the title
5 tasks
Florian Robel (frobel)
requested changes
Jun 25, 2026
| this.promotionLineItems = this.confirmProductTable.locator(".line-item-promotion"); | ||
| } | ||
|
|
||
| getLineItemByProductName(lineItem: Locator, productName: string): Record<string, Locator> { |
Contributor
There was a problem hiding this comment.
Why you have to provide a lineItem locator here? Could you not just take a line items and filter down to the specific one with .filter() like here
Author
There was a problem hiding this comment.
As each lineItem can be different types and will have many same assertion elements inside so i tried to make the code reusable but i updated the code based on your suggestion to align with existing code and easy to read
| } | ||
|
|
||
| async getLineItemByPromotionName(name: string): Promise<Record<string, Locator>> { | ||
| let promotionItem = this.page.locator(".line-item-promotion", { hasText: name }); |
Contributor
There was a problem hiding this comment.
why you use let as keyword here and not const?
| * | ||
| * @param customer - The customer whose email and profile data will be used for the newsletter recipient. | ||
| */ | ||
| async createNewsletterRecipient(customer: Customer): Promise<NewsletterRecipient> { |
Contributor
There was a problem hiding this comment.
I miss the overrides here so that we can modify the date etc. (see other create functions)
Author
There was a problem hiding this comment.
the overrides parameter is now added to createNewsletterRecipient func similar to other func
suri-ta777
force-pushed
the
test/add-checkout-with-promotion-discount-rule
branch
from
56cc2cb to
9688af6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Scenario Detail
Related to test
CheckoutWithPromotionRule.spec.tsin PR 17408