fix: cleanup for DefaultSalesChannel fixture#658
Draft
ravenokko wants to merge 12 commits into
Draft
Conversation
commit: |
5 tasks
This reverts commit 866171f.
…cleanUpDeleteOperationsResponse
…deleted when the associated product is
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
DefaultSalesChannelfixture isn't cleaned up, which is why our SaaS instances always contain sales channels/customer groups named "X acceptance test" and at least 1 customer named X Admin X Admin. This adds the functionality to delete the data created by theDefaultSalesChannelfixture.Note: Fixtures with
{ scope: worker }are automatically setup (when needed) before tests are run, with cleanup functionality after theawait use()function, when the worker is set to be deleted.Source: https://playwright.dev/docs/test-fixtures#execution-order